Merge pull request #155 from SemanticMediaWiki/migrate-registration-to-extension-json

Migrate extension registration to extension.json

Author: paladox

.phpcs.xml

@@ -13,8 +13,6 @@
 		<exclude name="MediaWiki.Commenting.PropertyDocumentation.WrongStyle" />
 		<exclude name="MediaWiki.Commenting.MissingCovers.MissingCovers" />
 		<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
-		<!-- Legacy entry-point filename (SemanticFormsSelect.hooks.php holds class Hooks). -->
-		<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
 		<!-- $IP in the test bootstrap is a MediaWiki core global. -->
 		<exclude name="MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix" />
 		<exclude name="Generic.Files.LineLength.TooLong" />

RELEASE-NOTES.md

@@ -10,6 +10,8 @@ Compatible with MediaWiki 1.43 up to 1.45, PHP 8.1 up to 8.4, and Semantic Media
 * Raised the minimum required Page Forms version to 6.0.6
 * Added support for Semantic MediaWiki 7.0
 * Migrated the query processing to Semantic MediaWiki 7.0's namespaced `SMW\Query\QueryProcessor` API
+* Completed the migration of extension registration to `extension.json` (declarative API module and autoloading, removed the procedural registration callback and the root entry-point file)
+* Removed the unused `$wgScriptSelectCount` configuration setting (it was read nowhere)
 
 ### 4.0.0
 

SemanticFormsSelect.hooks.php

@@ -51,11 +51,6 @@
 			"dev-master": "5.x-dev"
 		}
 	},
-	"autoload": {
-		"psr-4": {
-			"SFS\\": "src/"
-		}
-	},
 	"config": {
 		"process-timeout": 0,
 		"allow-plugins": {

composer.json

@@ -20,54 +20,46 @@
 			"PageForms": ">= 6.0.6"
 		}
 	},
-	"AutoloadClasses": {
-		"SFS\\Hooks": "SemanticFormsSelect.hooks.php",
-		"SFS\\SemanticFormsSelectInput": "src/SemanticFormsSelectInput.php",
-		"SFS\\Output": "src/Output.php",
-		"SFS\\SelectField": "src/SelectField.php",
-		"SFS\\ApiSemanticFormsSelectRequestProcessor": "src/ApiSemanticFormsSelectRequestProcessor.php",
-		"SFS\\ApiSemanticFormsSelect": "src/ApiSemanticFormsSelect.php"
+	"AutoloadNamespaces": {
+		"SFS\\": "src/"
 	},
 	"config": {
-		"ScriptSelectCount": {
-			"value": 0
-		},
 		"SF_Select_debug": {
 			"value": false
 		}
 	},
-	"callback": "SFS\\Hooks::onRegistration",
+	"APIModules": {
+		"sformsselect": "SFS\\ApiSemanticFormsSelect"
+	},
 	"MessagesDirs": {
 		"SemanticFormsSelect": [
 			"i18n"
 		]
 	},
+	"ResourceFileModulePaths": {
+		"localBasePath": "res",
+		"remoteExtPath": "SemanticFormsSelect/res"
+	},
 	"ResourceModules": {
 		"ext.sfs": {
 			"scripts": [
-				"res/pf.originalValueLookup.js",
-				"res/sfs.js",
-				"res/index.js"
+				"pf.originalValueLookup.js",
+				"sfs.js",
+				"index.js"
 			],
 			"styles": [
-				"res/select2.css"
+				"select2.css"
 			],
 			"dependencies": [
 				"ext.pageforms.main",
 				"ext.pageforms.select2"
-			],
-			"position": "bottom"
+			]
 		}
 	},
-	"ResourceFileModulePaths": {
-		"localBasePath": "",
-		"remoteExtPath": "SemanticFormsSelect"
-	},
 	"Hooks": {
 		"ParserFirstCallInit": [
 			"SFS\\Hooks::onSemanticFormsSelectSetup"
 		]
 	},
-	"load_composer_autoloader":true,
 	"manifest_version": 2
 }

extension.json

@@ -0,0 +1,29 @@
+<?php
+
+namespace SFS;
+
+use Parser;
+
+/**
+ * @license GPL-2.0-or-later
+ * @since 3.0
+ * @author Alexander Gesinn
+ */
+class Hooks {
+
+	/**
+	 * Register the Page Forms input type.
+	 *
+	 * Attached to the MediaWiki 'ParserFirstCallInit' hook.
+	 *
+	 * @param Parser $parser
+	 * @return bool
+	 */
+	public static function onSemanticFormsSelectSetup( Parser $parser ) {
+		if ( isset( $GLOBALS['wgPageFormsFormPrinter'] ) ) {
+			$GLOBALS['wgPageFormsFormPrinter']->registerInputType( SemanticFormsSelectInput::class );
+		}
+
+		return true;
+	}
+}