Skip to content

Commit 9aa7e8c

Browse files
committed
Move TopicScreen strings to resources
1 parent 7d45eae commit 9aa7e8c

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

  • feature/topic

‎feature/topic/api/src/main/res/values/strings.xml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,8 @@
1616
-->
1717
<resources>
1818
<string name="feature_topic_api_loading">Loading topic</string>
19+
<string name="feature_topic_api_loading_news">Loading news</string>
20+
<string name="feature_topic_api_news_error">Error</string>
21+
<string name="feature_topic_api_following">FOLLOWING</string>
22+
<string name="feature_topic_api_not_following">NOT FOLLOWING</string>
1923
</resources>

‎feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,11 +246,11 @@ private fun LazyListScope.userNewsResourceCards(
246246
}
247247

248248
is NewsUiState.Loading -> item {
249-
NiaLoadingWheel(contentDesc = "Loading news") // TODO
249+
NiaLoadingWheel(contentDesc = stringResource(TopicR.string.feature_topic_api_loading_news))
250250
}
251251

252252
else -> item {
253-
Text("Error") // TODO
253+
Text(stringResource(TopicR.string.feature_topic_api_news_error))
254254
}
255255
}
256256
}
@@ -308,9 +308,9 @@ private fun TopicToolbar(
308308
modifier = Modifier.padding(end = 24.dp),
309309
) {
310310
if (selected) {
311-
Text("FOLLOWING")
311+
Text(stringResource(TopicR.string.feature_topic_api_following))
312312
} else {
313-
Text("NOT FOLLOWING")
313+
Text(stringResource(TopicR.string.feature_topic_api_not_following))
314314
}
315315
}
316316
}

0 commit comments

Comments
 (0)