Fix createFile documentation and loadFile tests

Author: terryzfeng

dist/Chuck.d.ts

@@ -104,7 +104,7 @@ export default class Chuck extends window.AudioWorkletNode {
      * @param filename Name of file to create
      * @param data Data to write to the file
      */
-    createFile(directory: string, filename: string, data: string | ArrayBuffer): void;
+    createFile(directory: string, filename: string, data: string | Uint8Array): void;
     /**
      * Create a virtual directory in ChucK's filesystem.
      * @param parent Virtual directory to create the new directory in
@@ -272,7 +272,8 @@ export default class Chuck extends window.AudioWorkletNode {
     /**
      * Remove a shred from ChucK VM by ID
      * @param shred Shred ID to be removed
-     * @returns Promise to shred ID if removed successfully, otherwise "removing code failed"
+     * @returns Promise to shred ID if removed successfully, otherwise rejects
+     * with "Removing code failed"
      */
     removeShred(shred: number | string): Promise<number>;
     /**

dist/Chuck.js

@@ -208,7 +208,7 @@ export default class Chuck extends window.AudioWorkletNode {
                 this.createFile("", filename, data);
             }
             else {
-                this.createFile("", filename, data);
+                this.createFile("", filename, new Uint8Array(data));
             }
         })
             .catch((err) => {
@@ -454,7 +454,8 @@ export default class Chuck extends window.AudioWorkletNode {
     /**
      * Remove a shred from ChucK VM by ID
      * @param shred Shred ID to be removed
-     * @returns Promise to shred ID if removed successfully, otherwise "removing code failed"
+     * @returns Promise to shred ID if removed successfully, otherwise rejects
+     * with "Removing code failed"
      */
     removeShred(shred) {
         const callbackID = this.nextDeferID();

src/Chuck.ts

@@ -197,7 +197,7 @@ export default class Chuck extends window.AudioWorkletNode {
    * @param filename Name of file to create
    * @param data Data to write to the file
    */
-  public createFile(directory: string, filename: string, data: string | ArrayBuffer) {
+  public createFile(directory: string, filename: string, data: string | Uint8Array) {
     this.sendMessage(OutMessage.CREATE_FILE, {
       directory,
       filename,
@@ -239,7 +239,7 @@ export default class Chuck extends window.AudioWorkletNode {
         if (isText) {
           this.createFile("", filename, data as string);
         } else {
-          this.createFile("", filename, data as ArrayBuffer);
+          this.createFile("", filename, new Uint8Array(data as ArrayBuffer));
         }
       })
       .catch((err) => {

src/wc-bundle.js

@@ -372,7 +372,7 @@ class Chuck extends window.AudioWorkletNode {
                 this.createFile("", filename, data);
             }
             else {
-                this.createFile("", filename, data);
+                this.createFile("", filename, new Uint8Array(data));
             }
         })
             .catch((err) => {
@@ -618,7 +618,8 @@ class Chuck extends window.AudioWorkletNode {
     /**
      * Remove a shred from ChucK VM by ID
      * @param shred Shred ID to be removed
-     * @returns Promise to shred ID if removed successfully, otherwise "removing code failed"
+     * @returns Promise to shred ID if removed successfully, otherwise rejects
+     * with "Removing code failed"
      */
     removeShred(shred) {
         const callbackID = this.nextDeferID();

test/chuckTest.js

@@ -284,7 +284,7 @@ TestSuite.test("[sound] Dynamic load in a kick wav file from URL", async (t) =>
     () => {
       aChuck.runCode(code);
     },
-    (output) => output === "KICKED",
+    (output) => output.includes("KICKED"),
     2000,
   );
   t.assert(passed, "Should have printed KICKED");
@@ -351,10 +351,8 @@ TestSuite.test("Test shred management, add, remove, replace", async (t) => {
 
   t.assert((await aChuck.removeLastCode()) === shred2, "removeLastCode should return shred2");
 
-  const { oldShred, newShred } = await aChuck.replaceCode(`
-    <<< "REPLACE Shred 1 with a new program", "" >>>;
-    1::week => now;
-  `,
+  const { oldShred, newShred } = await aChuck.replaceCode(
+    `<<< "REPLACE Shred 1 with a new program", "" >>>; 1::week => now;`,
     shred1,
   );
   t.assert(
@@ -487,6 +485,7 @@ TestSuite.test("WebChucK get deferred Promise<type> returns", async (t) => {
 });
 
 TestSuite.test("[sound] WebChugin Test, ABSaturator", async (t) => {
+  Chuck.loadChugin("./testFiles/ABSaturator.chug.wasm");
   const aChuck = await setupChuck(t);
   const code = `SinOsc osc => Delay d => ABSaturator sat => dac;
     20 => sat.drive;