Implement sanitizer builds, update Makefile patch, and add issue #261 reference

Author: RageLiu

.github/workflows/ci.yml

@@ -14,6 +14,8 @@ jobs:
     env:
       CC: ${{matrix.cc}}
       CXX: ${{matrix.cxx}}
+      CXXFLAGS: ${{matrix.env_cxxflags}}
+      LDFLAGS: ${{matrix.env_ldflags}}
     defaults:
       run:
         shell: bash
@@ -51,13 +53,15 @@ jobs:
             cxx: clang++-19
             os: ubuntu-latest
             container: ubuntu:24.04
-            build_options: "CXXFLAGS='-fsanitize=address,undefined -g' LDFLAGS='-fsanitize=address,undefined'"
+            env_cxxflags: "-fsanitize=address,undefined"
+            env_ldflags: "-fsanitize=address,undefined"
 
           - name: clang-sanitizer-macOS
             cc: clang
             cxx: clang++
             os: macos-latest
-            build_options: "CXXFLAGS='-fsanitize=address,undefined -g' LDFLAGS='-fsanitize=address,undefined'"  
+            env_cxxflags: "-fsanitize=address,undefined"
+            env_ldflags: "-fsanitize=address,undefined"
 
     steps:
       - name: Checkout

Makefile

@@ -36,7 +36,9 @@ GMAKE = make mode=$(mode)
 NAME := sqlparser
 PARSER_CPP = $(SRCPARSER)/bison_parser.cpp  $(SRCPARSER)/flex_lexer.cpp
 PARSER_H   = $(SRCPARSER)/bison_parser.h    $(SRCPARSER)/flex_lexer.h
-LIB_CFLAGS = -std=c++17 $(OPT_FLAG)
+LIB_CFLAGS = -std=c++17 $(OPT_FLAG) $(CXXFLAGS)
+LIB_LFLAGS = $(LDFLAGS)
+
 
 relaxed_build ?= "off"
 ifeq ($(relaxed_build), on)
@@ -54,12 +56,12 @@ static ?= no
 ifeq ($(static), yes)
 	LIB_BUILD  = lib$(NAME).a
 	LIBLINKER  = $(AR)
-	LIB_LFLAGS = rs
+	LIB_LFLAGS += rs
 else
 	LIB_BUILD   = lib$(NAME).so
 	LIBLINKER   = $(CXX)
 	LIB_CFLAGS += -fPIC
-	LIB_LFLAGS  = -shared -o
+	LIB_LFLAGS += -shared -o
 endif
 LIB_CPP = $(sort $(shell find $(SRC) -name '*.cpp' -not -path "$(SRCPARSER)/*") $(PARSER_CPP))
 LIB_H   = $(shell find $(SRC) -name '*.h' -not -path "$(SRCPARSER)/*") $(PARSER_H)

test/sql_parser.cpp

@@ -43,6 +43,7 @@ TEST(SQLParserTokenizeStringifyTest) {
   ASSERT(&query != &cache[token_string]);
 }
 
+// Regression test for the memory leak reported in issue #261.
 TEST(SQLParserTokenizeLeakRegressionTest) {
 
   const std::string query = "'string_1' 'string_2' 'string_3';";
@@ -55,4 +56,4 @@ TEST(SQLParserTokenizeLeakRegressionTest) {
   ASSERT_EQ(tokens[1], SQL_STRING);
   ASSERT_EQ(tokens[2], SQL_STRING);
   ASSERT_EQ(tokens[3], ';');
-}
+}