Add Fortran export selection and PRIMA static-library example - #72
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--export-symbolsandbuild_fortran_extension(export_symbols=...)to case-insensitive Fortranmodule::procedureidentities. Only declared Fortran modules can satisfy the module side; source builds and generated-contract builds publish the same selected callable surface.libprimaf.a; PRIK analyzes that source universe, emits contracts for five selected solvers and their callback dependency, then links the wrapper to the archive.Review guide
Most of the roughly 29,000 added lines are the unmodified, licensed PRIMA Fortran snapshot pinned to upstream commit
1d76fb88aeffb427cd17ed1e9d0d3b34f414913f. The PRIK implementation is concentrated inprik/semantics/fortran_exports.py, the CLI/source-build integration, and contract dependency emission. The wrapper planner and callback backends are unchanged.The relevant behavior tests are in
tests/fortran/functions/semantics/test_fortran_export_symbol_selection.pyandtests/fortran/functions/end_to_end/test_fortran_export_symbol_workflow.py. They cover qualified-name validation, a real module colliding with a synthetic external root, generic-interface selection, and source-build versus generated-contract parity. The maintained runtime example isexamples/fortran/prima/tests/test_solvers.py.Verification
The four-target hosted portability run is configured by this PR and will provide its platform results in GitHub Actions.