Skip to content

Select and Datepicker popovers are portrait-only on iPad because supportedOrientations is not forwarded聽#1911

Description

@sergeushenecz

馃悰 Bug Report

Popover renders its content in a React Native Modal and passes supportedOrientations straight through, with no default. On iOS a Modal without supportedOrientations only supports portrait, so a popover opened while an iPad is in landscape is presented in portrait orientation.

Popover itself and OverflowMenu (which spreads its props into Popover) let the app pass supportedOrientations, but Select, Datepicker and RangeDatepicker create their Popover with a fixed set of props and do not forward it, so there is no way to fix it from the app.

To Reproduce

  1. Run an app that supports landscape (supportsTablet: true, all orientations allowed) on an iPad.
  2. Rotate the iPad to landscape.
  3. Open a Select or a Datepicker.
  4. The popover is presented in portrait orientation instead of following the app.

Expected behavior

The popover follows the orientation of the app. Either Popover defaults supportedOrientations to all orientations (the app's Info.plist still restricts it), or Select / Datepicker / RangeDatepicker forward supportedOrientations to their Popover.

We currently patch Popover to default to ['portrait', 'portrait-upside-down', 'landscape', 'landscape-left', 'landscape-right'].

UI Kitten and Eva version

Package Version
@ui-kitten/eva 6.0.2
@ui-kitten/components 6.1.3

Environment information

React Native 0.86.3, React 19.2.3, Expo SDK 57, iPadOS.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions