MINOR: Fix Quickstart plugin.path link - #23598
Open
peterhyliao wants to merge 2 commits into
Open
peterhyliao wants to merge 2 commits into
peterhyliao wants to merge 2 commits into
Conversation
Contributor
|
LGTM |
Parkerhiphop
left a comment
Parkerhiphop
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch.
Contributor
There was a problem hiding this comment.
Would you mind updating the links that hardcode /43/ to use /{version}/ as well?
Also, /documentation/streams/xxx paths are redirect pages. Could you update them to use the current Streams paths as well, e.g. /{version}/streams/quickstart and /{version}/streams/tutorial?
Contributor
Author
There was a problem hiding this comment.
Sure. Updated the Streams links to use /{version}/ and the current /streams/... paths. I also verified both targets locally with the kafka-site build. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
plugin.pathlink in the Quickstart currently uses a relative URL. This works on the versioned Quickstart page, but the same rendered content is also included in the top-level/quickstart/page, where the relative URL resolves to a non-versioned path and returns 404.This change uses the existing
/{version}/...link format so the link resolves correctly from both the versioned and top-level Quickstart pages.Verified locally with the Kafka site Hugo build.
Reviewers: Andy Huang (github:andyhuangdev), Parker Chang parkerhiphop027@gmail.com