Add a success animation before the booking plane morph - #6
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The reduced-motion completion path lacks automated regression coverage.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds a booking-success animation before navigating via the existing plane morph.
Changes:
- Adds pending/success overlay states, inert content, and reduced-motion handling.
- Prefetches and navigates client-side after confirmation.
- Updates Next.js tooling and Playwright coverage.
| File | Description |
|---|---|
features/booking/booking-actions.ts |
Returns successful booking details. |
features/booking/components/booking-step-form.tsx |
Coordinates success state, prefetch, and navigation. |
features/booking/components/confirm-overlay.tsx |
Implements the confirmation overlay. |
features/booking/components/confirm-overlay.module.css |
Defines success animations. |
tests/booking-flow.spec.ts |
Tests success and validation flows. |
package.json |
Updates Next.js packages. |
pnpm-lock.yaml |
Locks updated dependencies. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+44
to
+45
| const reducedMotion = window.matchMedia('(prefers-reduced-motion: reduce)').matches; | ||
| const timer = window.setTimeout(onComplete, reducedMotion ? 150 : 850); |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fast booking previously redirected before confirmation had a moment to register. After the booking succeeds, show a brief animated green ring and check around the plane, then navigate using the existing shared-element plane morph.
The destination prefetches during the success beat. The underlying page stays inert while confirming, validation failures return to the form, and reduced motion disables the success animation and shortens the pause. Next.js and its matching tooling are updated to canary.51 per repository instructions.
Validation: TypeScript, formatting, and Next.js compilation/runtime checks pass. ESLint has one existing import-order warning in components/ui/error-state.tsx. Verified successful booking, the plane morph, validation-error recovery, and reduced-motion completion in the local browser. Added Playwright regression assertions; the Playwright suite was not run.