Update packages and fix unit test errors in conformal - #293
Merged
c-w-feldmann merged 14 commits intoJul 14, 2026
Merged
c-w-feldmann merged 14 commits into
c-w-feldmann merged 14 commits into
Conversation
Collaborator
Author
|
Fixed the errors. Waiting for the new rdkit release, so that mypy works again. |
c-w-feldmann
changed the title
c-w-feldmann
commented
Jul 2, 2026
c-w-feldmann
commented
Jul 14, 2026
| return last_step.classes_ | ||
| raise ValueError("Last step has no classes_ attribute.") | ||
| raise AttributeError( | ||
| f"'{type(self).__name__}' object has no attribute 'classes_'", |
Collaborator
Author
There was a problem hiding this comment.
To match sklearn behaviour, which also expects an AttributeError
c-w-feldmann
marked this pull request as ready for review
July 14, 2026 08:25
soulios-basf
approved these changes
Jul 14, 2026
soulios-basf
left a comment
soulios-basf
left a comment
Collaborator
There was a problem hiding this comment.
looks good and thanks for taking care of it!
c-w-feldmann
deleted the
292-update-packages-and-fix-unit-test-errors-in-conformal
branch
July 14, 2026 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.