Skip to content

Enable Set Router execution on the Swap page #49

Description

@stxphxn

Summary

Migrate BSC testnet swaps from direct Set contract execution to the deployed Set Router while preserving pool/poolId internally and using Set in user-facing copy.

Current gap

The Swap page still requests direct firm quotes, approves the Set contract, checks wallet-to-Set allowance, and accepts direct swapExact... calldata. Router-mode RFQ responses target 0x00355Ed1Fc7cD618AEC5A8E8fD31686376499ccB, require wallet-to-Router approval, include nested Router authorization, and execute swapSetwise.

Required outcomes

  • Router-mode firm quotes are requested and validated fail-closed.
  • ERC20 approvals and allowance reads target only the verified Router.
  • ERC20-to-ERC20, native-to-ERC20, and ERC20-to-native swaps work from the Swap page.
  • Stale, wrong-chain, wrong-Router, modified-calldata, paused, and replayed submissions remain blocked.
  • The app performs submission preflight and records confirmed activity.
  • Deposits and withdrawals remain direct-to-Set.

External prerequisites

Difficulty

High — cross-cutting wallet, schema, authorization, execution, and release work.

Completion

Complete all linked sub-issues and the BSC testnet wallet smoke matrix before deploying the app.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: integrationRoute, navigation, state, and feature integrationarea: swapsSwap quoting, approval, execution, and transaction experiencedifficulty: highCross-cutting or state-sensitive task; use the strongest coding modelenhancementNew feature or requesttrackingTracking issue that coordinates multiple implementation tickets

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions