fix(ui): restore paginator key map in file list - #1039
Open
costajohnt wants to merge 1 commit into
Open
costajohnt wants to merge 1 commit into
costajohnt wants to merge 1 commit into
Conversation
The bubbletea v2 migration replaced paginator.New() with a struct literal, leaving the stash paginators with an empty KeyMap and ArabicFormat. h/l, left/right and pgup/pgdown no longer paged, and the narrow-terminal arabic fallback rendered a format error. Fixes charmbracelet#1037
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Since v3.0.0 the stash sections build their paginator as
paginator.Model{Type: paginator.Dots}instead of going throughpaginator.New(). The zero-value model has an emptyKeyMap(and noArabicFormat), soh/l, the arrow keys and PgUp/PgDn stopped changing pages in the file list.This adds a small
newStashPaginator()helper that starts frompaginator.New()and setsType = paginator.Dots, and uses it for both sections. Nothing else about the paginator changes.Tests: new
ui/stash_test.godriveshandleDocumentBrowsingwithl, right, PgDn,h, left and PgUp and checks the page moves, plus a check that the Arabic fallback renders1/3. Both fail onmainand pass with the change.go test ./...andgo vet ./...pass.