ci: build linux/arm64 images via docker/github-builder reusable workflow - #212
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Docker workflow now delegates image building and publishing to ChangesDocker workflow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The workflow is ready to merge after normal checks: the new job sequencing targets the newly built main-branch image, with no actionable risk established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description does not follow the repository template. It omits the required Description, Changes, and How to test sections, and it contradicts the changeset by stating that autodeploy remains in the same job and that the workflow uses QEMU with a minimal diff. Resolution Rewrite the description using the required Description, Changes, and How to test sections. Describe the switch to the docker/github-builder reusable workflow, the separate autodeploy job with needs: docker, registry authentication, multi-platform configuration, and the tests for both platform builds, the manifest, and autodeploy.
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4253212 to
b16f279
Compare
|
@mateipopa come sign the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
Summary
linux/arm64to the existingdockerjob via the minimal diff:docker/setup-qemu-action+docker/setup-buildx-actionsteps, andplatforms: linux/amd64,linux/arm64on the existingdocker/build-push-actionstep.autodeploystep stays in the same job, unchanged — no job split needed this time.ubuntu-latestrunner. This repo's build has no heavy native compile step, so the emulation cost is expected to be acceptable.main, so no signed-commit or required-check concerns.