fix(http): handle empty Cookie headers - #7328
Open
dennisimoo wants to merge 2 commits into
Open
dennisimoo wants to merge 2 commits into
dennisimoo wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7328 +/- ##
==========================================
- Coverage 95.04% 95.04% -0.01%
==========================================
Files 618 620 +2
Lines 51746 52016 +270
Branches 9402 9452 +50
==========================================
+ Hits 49181 49437 +256
- Misses 2022 2031 +9
- Partials 543 548 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks for the PR, it looks mostly okay. I'm still wary that it will throw on |
Contributor
Author
|
Handled in ff38944. Empty cookie pairs are now skipped, including |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7320.
Treat an empty Cookie header like a missing header and ignore empty cookie pairs, including trailing semicolons. Preserve nonempty values and existing malformed-key validation.
Regression tests cover empty headers, empty pairs, whitespace, and malformed keys. The new trailing-semicolon test failed before the fix.
Tests:
deno test -A --doc http/— 479 passed, 987 steps, 2 ignored. Full lint, formatting and browser checks passed. The earlier fulldeno task okrun was killed (exit 137) in the unrelated CBOR test that allocates a 4–8 GiB buffer, including on a serial retry.AI-assisted with Codex.