chore: run Bun tests with --tsconfig-override - #7338
Open
tomas-zijdemans wants to merge 1 commit into
Open
tomas-zijdemans wants to merge 1 commit into
tomas-zijdemans wants to merge 1 commit into
Conversation
deno task test:bun copied the Bun config to ./tsconfig.json and removed it after the run. That overwrote any local tsconfig.json at the repo root, and a failing test skipped the rm and left the copy behind. Pass the config with --tsconfig-override instead, and make its paths relative to _tools/node_test_runner/ where it lives.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7338 +/- ##
==========================================
- Coverage 95.04% 94.95% -0.10%
==========================================
Files 619 618 -1
Lines 52012 51757 -255
Branches 9450 9379 -71
==========================================
- Hits 49434 49145 -289
- Misses 2031 2056 +25
- Partials 547 556 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tomas-zijdemans
changed the title
--tsconfig-override
tomas-zijdemans
force-pushed
the
chore/testing-bun-tsconfig-override
branch
from
September 28, 2026 17:14
2e4432d to
be97400
Compare
tomas-zijdemans
changed the title
--tsconfig-override
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root
tsconfig.jsonstays put.deno task test:bunpasses the runner config through--tsconfig-overrideinstead of copying it into the repo root.The old task copied over that gitignored file. A passing run deleted it, while a failing run left the copy behind.
The config stays in
_tools/node_test_runner/, with itspathsentries relative to that directory. The root ignore rule stays for contributors' local configs.Tested with Bun 1.4.2: with a deliberately broken root
tsconfig.json, 735 tests passed, 24 were skipped, and the file was left untouched. Without the override, Bun failed to resolve@std/path. Bun prints a non-fatal directory mismatch warning with this flag, and the Bun CI job passes.I used Claude Code to help investigate and write this change.