Conversation
…ons, and duplicate bounding_box keys (graphistry#1968) Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix/circle-layout-entry-guards
branch
from
September 25, 2026 17:02
b34879f to
cc35306
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the three entry-guard crashes from #1968: nodes are now materialized before being counted so an edge-only graph lays out instead of hitting
TypeError: object of type 'NoneType' has no len(); the no-argument form on a graph without x/y positions raises a ValueError naming the documented precondition instead of a bareKeyError: 'x'; and a partition-keyed bounding_box frame with duplicate partition_key values raises a ValueError naming the duplicates instead of a pandas IntCastingNaNError from the row-multiplying merge. Non-goals: defects 4 and 5 from the issue (the misleading null-partition-key message and the dead engine comparison) are left untouched.Validation
graphistry/tests/layoutgreen including the newtest_circle_entry_guards.py)Cypher Frontend CI Evidence (when PR touches cypher frontend / IR scope)
Not applicable — layout-only change.