Handle GPX byte-order marks and XML encodings - #194
Merged
jenetics merged 1 commit intoSep 18, 2026
Merged
Conversation
Owner
|
@bensynapse Thank you for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Fixes #190.
GPX.read(Path)rejects the supplied UTF-8 BOM file becauseInputStreamReaderturns its encoding marker into prolog text before StAX sees it. Pass byte streams directly to the XML parser through the existing non-closing wrapper, allowing it to consume byte-order marks and honor declared encodings. UseStringReaderforfromStringso already-decoded text keeps its existing behavior.Validation on Linux with Temurin 25:
./gradlew build --stacktrace --infopasses all 1,000 tests and builds the library, source and Javadoc JARs.