[api] Fix a couple type cache issues - #64408
Merged
Andrew Branch (andrewbranch) merged 2 commits intoSep 23, 2026
Merged
Andrew Branch (andrewbranch) merged 2 commits into
Andrew Branch (andrewbranch) merged 2 commits into
Conversation
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Copilot started reviewing on behalf of
Andrew Branch (andrewbranch)
September 23, 2026 16:23
View session
|
|
||
| - Does the public method take arguments, like `type.getProperty(name)`? | ||
| - Add the method on `Type` | ||
| - Add an equivalent method on `Checker` |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The index-type cache fix lacks request-count regression coverage, and its new guidance excludes the discriminator-based pattern implemented here.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
This PR fixes API type-cache consistency and removes the redundant index-type protocol endpoint.
Changes:
- Cache constituent type arrays in sync and async clients.
- Delegate checker index-type lookups to cacheable
Typemethods. - Update protocol definitions, tests, and API-client guidance.
| File | Description |
|---|---|
.github/skills/api-client/SKILL.md |
Documents checker delegation guidance. |
tsc/internal/api/session.go |
Removes the redundant request handler. |
tsc/internal/api/proto.go |
Removes the obsolete protocol method. |
packages/typescript/src/api/proto.generated.ts |
Updates generated protocol types. |
packages/typescript/src/api/sync/api.ts |
Adds caching and checker delegation. |
packages/typescript/src/api/async/api.ts |
Mirrors cache fixes asynchronously. |
packages/typescript/test/sync/api.test.ts |
Tests constituent-array identity. |
packages/typescript/test/async/api.test.ts |
Tests async constituent-array identity. |
Andrew Branch (andrewbranch)
requested a review
from Gabriela Araujo Britto (gabritto)
September 23, 2026 16:39
Gabriela Araujo Britto (gabritto)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote these instructions in #64397; following up to make sure existing stuff actually follows them.