fix(cli): accept install-browser --no-shell - #42871
Conversation
Test results for "tests 1"8 flaky52148 passed, 1253 skipped Merge workflow run. |
Test results for "MCP"1 failed 8704 passed, 1474 skipped Merge workflow run. |
🟢 CI is clear — the one failure is a known Windows/Firefox flakeHi, I'm the Playwright bot and I triaged the CI failures here.
DetailsPre-existing flake / infra
Flaky (passed on retry)
Triaged by the Playwright bot - agent run |
0406789
into
microsoft:main
## Fixes - `run-code` scripts can use timers, `fetch`, `URL`, `Buffer`, `crypto`, `AbortController` and `TextEncoder`/`TextDecoder`; `require` and `process` stay unavailable ([#471](#471)). ([microsoft/playwright#42975](microsoft/playwright#42975)) - `find --filename=results.md` saves matches to a file when a query produces too many of them ([microsoft/playwright#42077](microsoft/playwright#42077)). ([microsoft/playwright#42968](microsoft/playwright#42968)) - `goto` and `reload` report a dialog opened during page load instead of timing out ([microsoft/playwright#42817](microsoft/playwright#42817)). ([microsoft/playwright#42908](microsoft/playwright#42908)) - The session no longer crashes when the browser is closed during a download ([microsoft/playwright#42831](microsoft/playwright#42831)). ([microsoft/playwright#42922](microsoft/playwright#42922)) - `install-browser --no-shell` is accepted instead of failing with `Unknown option: --shell` ([microsoft/playwright#42804](microsoft/playwright#42804)). ([microsoft/playwright#42871](microsoft/playwright#42871)) - `webmcp-call` no longer runs a tool in a stale tab or frame ([microsoft/playwright#42816](microsoft/playwright#42816)). ([microsoft/playwright#42821](microsoft/playwright#42821)) - `webmcp-call` works with Chromium 155+. ([microsoft/playwright#42915](microsoft/playwright#42915)) - Snapshots quote accessible names that look like regexes, e.g. `"/home/"` ([microsoft/playwright#42807](microsoft/playwright#42807)). ([microsoft/playwright#42811](microsoft/playwright#42811)) - The bundled skill only preapproves Playwright commands instead of any `npm` and `npx` command ([microsoft/playwright#42745](microsoft/playwright#42745)). ([microsoft/playwright#42789](microsoft/playwright#42789))
Summary
playwright-cli install-browser --no-shellwas rejected withUnknown option: --shell: minimist parses it as{ shell: false }, but the command declaresno-shell. Flag validation now accepts negated flags declared asno-*.noShelloption frominstallBrowsers.Fixes #42804