Fix missed ORLY_PLATFORM rename — Docker was downloading wrong tarball - #90
Merged
Merged
Conversation
setup-deps-tarball.sh still read ORLY_PLATFORM which caused the Docker publish to download the ubuntu-22.04 tarball instead of bookworm, leading to glog ABI mismatch.
gmarzot
added a commit
to openmoq/moxygen
that referenced
this pull request
Mar 29, 2026
The hash rollback (PRs #97, #98) was unnecessary — the real issue was moqx downloading the wrong platform tarball (ubuntu instead of bookworm) due to a missed ORLY_PLATFORM rename. Fixed in openmoq/moqx#90. Restores all dep hashes to the current upstream versions.
2 tasks
gmarzot
added a commit
to openmoq/moxygen
that referenced
this pull request
Mar 29, 2026
The hash rollback (PRs #97, #98) was unnecessary — the real issue was moqx downloading the wrong platform tarball (ubuntu instead of bookworm) due to a missed ORLY_PLATFORM rename. Fixed in openmoq/moqx#90. Restores all dep hashes to the current upstream versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rename PR missed
ORLY_PLATFORMinscripts/setup-deps-tarball.sh.CI sets
MOQX_PLATFORM=bookworm-amd64but the script readORLY_PLATFORM,fell back to
detect_platform()which returnedubuntu-22.04-amd64.This caused the Docker publish to download the ubuntu tarball instead of
bookworm, leading to the glog ABI link failure.
Also fixes
ORLY_SCRATCH_PATHinsetup-deps-tarball.shandconfigure.sh.Test plan
This change is