Test ST_ClustersTest Failed

[nathan-marie]

The error message is :

[ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.129 s <<< FAILURE! -- in org.h2gis.functions.spatial.clusters.ST_ClustersTest
[ERROR] org.h2gis.functions.spatial.clusters.ST_ClustersTest.st_clusterDBSCAN1 -- Time elapsed: 0.006 s <<< ERROR!
org.h2.jdbc.JdbcSQLSyntaxErrorException: 
Méthode "ST_DWITHIN (org.h2gis.functions.spatial.predicates.ST_DWithin, parameter count: 4)" non trouvée
Method "ST_DWITHIN (org.h2gis.functions.spatial.predicates.ST_DWithin, parameter count: 4)" not found; SQL statement:
CREATE CACHED LOCAL TEMPORARY TABLE tmp_pairs AS SELECT a.id AS id_a, b.id AS id_b FROM SAMPLE_POINTS a, SAMPLE_POINTS b WHERE a.id < b.id AND ST_EXPAND(a.the_geom, 50,000000) && b.the_geom AND ST_DWithin(a.the_geom, b.the_geom, 50,000000) [90087-240]

The error come from the fact that 50,000000 is written with a comma, not with a dot.

[nicolas-f]

Hello,

Yes we should have use Locale.ROOT instead of system locale

--- h2gis-functions/src/main/java/org/h2gis/functions/spatial/clusters/ClusterDBSCAN.java
+++ h2gis-functions/src/main/java/org/h2gis/functions/spatial/clusters/ClusterDBSCAN.java
@@ -102,9 +102,9 @@
             return;
         }
 
         // Materialise pairs once (CACHED = B-tree on disk, no OOM risk)
-        String createPairsSql = String.format(
+        String createPairsSql = String.format(Locale.ROOT,
                 "CREATE CACHED LOCAL TEMPORARY TABLE tmp_pairs AS " +
                         "SELECT a.%s AS id_a, b.%s AS id_b " +
                         "FROM %s a, %s b " +
                         "WHERE a.%s < b.%s " +

[nathan-marie]

Thanks, I created a pull request with the change in ClusterDBSCAN.java

[nathan-marie]

Issue resolve with PR #1486, commit e71cc67