Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An RTSP producer can initially advertise video without dimensions, then correct its codec description after media starts arriving. FMP4Stream can proceed with the incomplete first description and fail while writing the MP4 header.
Retry the RTSP open once when video dimensions are missing, keeping the first connection alive while fetching the new description. Await closure of the original input on both success and failure and preserve the startup abort signal. File inputs and caller-provided demuxers are unchanged; this is not an unbounded reconnect loop.
Tests inject an incomplete first description, verify a usable init segment after the second open, and verify that the initial input closes if refreshing fails. The existing shutdown and stalled-source tests remain in place.
Validation: all 22 FMP4Stream tests passed with the current upstream source and published native binding; lint, TypeScript build, test and example typechecks passed. Full CI-mode suite: 2,082 passed, six hardware tests skipped, zero failures. Kept as a draft for review of the RTSP-specific recovery policy: the deterministic regression validates recovery/resource handling, while exact camera timing remains device-dependent.