Skip to content

log: focus finite-page Tiger Lake capture on GPU bring-up and failures - #52

Merged
t4ce merged 4 commits into
truefrom
diag/tgl-gpu-log-profile
Sep 18, 2026
Merged

t4ce merged 4 commits into
truefrom
diag/tgl-gpu-log-profile

Conversation

@t4ce

@t4ce t4ce commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Focus the existing log_os policy for the laptop diagnostic

The first LastAP/MicroFont capture reached SCREEN FULL with USB controller and Render/Info font-tessel output, while the default Gfx/Gpgpu policies suppressed useful initialization/admission records. This PR changes the acceptance profile, not the logger or the driver.

src/log_os.rs::flags::TGL_GPU_DIAG_PROFILE_ENABLED = true selects:

Semantic area Effective policy
Gfx, Gpgpu Up(Info)
Render, Boot, Service Up(Once)
All other areas Up(Warn)

This preserves every area's Error/Important/Warn; keeps Intel claim/cache/PAT, GuC firmware/bootstrap/admission, panel/plane-stack and GPGPU setup evidence; filters unrelated informational traffic and Render/Info per-stage/poll/retry dumps. No Debug/Trace is enabled. Up(Once) uses the existing severity order; it is not a new rate limiter.

The switch has explicit precedence over the other diagnostic profiles. It is compile-time and build-wide, not a runtime PCI filter. Setting it false restores all pre-existing profile settings. A Boot/Important log-profile=tgl-gpu-first-v1 banner identifies the chosen policy in the mirrored transcript.

Unchanged: TCP formatting and 256 KiB ring, UART routing, LastAP placement, MicroFont task, page-full behavior, UI4/Spirit, shaders and all hardware execution/readiness gates. No new queue, screen filter, sampling framework, or driver instrumentation.

The policy does intentionally filter Render/Info boot summaries too; GuC bootstrap/admission is retained in Gfx/Info. UI4 maps to Global and retains warnings/errors without enabling its per-frame Trace stream. Repeated warnings/errors can still fill a finite page; they are not suppressed or falsely promised to fit.

Only 25 added runtime lines in src/log_os.rs. The other files document the profile and test it.

Validation — passed

Read-only CI succeeded on head 78b8e87cb030dba40d0dd4c95fd83b55b32819a0:
https://github.com/t4ce/TRUEOS/actions/runs/35307226612/job/105481788907

Four compiled Rust tests passed in each of three configurations (12 test runs total): profile enabled, disabled/baseline, and enabled with every competing diagnostic switch also enabled. Tests compile the actual production flags, actual TcpLogSink/EmulatorUartLogSink adapters and shared log-os router, with only physical writes replaced by collectors. They cover all 16 areas × 7 levels, real target-to-area classification, retention of severe records, sink agreement, fallback restoration, and profile precedence.

tools/trueos-doc topic logs returned successfully. rustfmt --emit stdout parsed src/log_os.rs successfully without modifying it. Reviewed the runtime commit diff: only the profile switch, central area-policy override and banner were added.

This is not a full kernel build or laptop boot. No changes to true and no rig reset/deployment.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 387d1be0-81d1-4972-a4fb-a7e224608210


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@t4ce
t4ce merged commit f2a389e into true Sep 18, 2026
4 checks passed
@t4ce
t4ce deleted the diag/tgl-gpu-log-profile branch September 23, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant