log: focus finite-page Tiger Lake capture on GPU bring-up and failures - #52
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focus the existing log_os policy for the laptop diagnostic
The first LastAP/MicroFont capture reached SCREEN FULL with USB controller and Render/Info font-tessel output, while the default Gfx/Gpgpu policies suppressed useful initialization/admission records. This PR changes the acceptance profile, not the logger or the driver.
src/log_os.rs::flags::TGL_GPU_DIAG_PROFILE_ENABLED = trueselects:This preserves every area's Error/Important/Warn; keeps Intel claim/cache/PAT, GuC firmware/bootstrap/admission, panel/plane-stack and GPGPU setup evidence; filters unrelated informational traffic and Render/Info per-stage/poll/retry dumps. No Debug/Trace is enabled.
Up(Once)uses the existing severity order; it is not a new rate limiter.The switch has explicit precedence over the other diagnostic profiles. It is compile-time and build-wide, not a runtime PCI filter. Setting it false restores all pre-existing profile settings. A Boot/Important
log-profile=tgl-gpu-first-v1banner identifies the chosen policy in the mirrored transcript.Unchanged: TCP formatting and 256 KiB ring, UART routing, LastAP placement, MicroFont task, page-full behavior, UI4/Spirit, shaders and all hardware execution/readiness gates. No new queue, screen filter, sampling framework, or driver instrumentation.
The policy does intentionally filter Render/Info boot summaries too; GuC bootstrap/admission is retained in Gfx/Info. UI4 maps to Global and retains warnings/errors without enabling its per-frame Trace stream. Repeated warnings/errors can still fill a finite page; they are not suppressed or falsely promised to fit.
Only 25 added runtime lines in src/log_os.rs. The other files document the profile and test it.
Validation — passed
Read-only CI succeeded on head
78b8e87cb030dba40d0dd4c95fd83b55b32819a0:https://github.com/t4ce/TRUEOS/actions/runs/35307226612/job/105481788907
Four compiled Rust tests passed in each of three configurations (12 test runs total): profile enabled, disabled/baseline, and enabled with every competing diagnostic switch also enabled. Tests compile the actual production flags, actual TcpLogSink/EmulatorUartLogSink adapters and shared log-os router, with only physical writes replaced by collectors. They cover all 16 areas × 7 levels, real target-to-area classification, retention of severe records, sink agreement, fallback restoration, and profile precedence.
tools/trueos-doc topic logsreturned successfully.rustfmt --emit stdoutparsed src/log_os.rs successfully without modifying it. Reviewed the runtime commit diff: only the profile switch, central area-policy override and banner were added.This is not a full kernel build or laptop boot. No changes to
trueand no rig reset/deployment.