connection: fix race on future release - #597
Merged
Merged
Conversation
oleg-jukovec
force-pushed
the
oleg-jukovec/fix-unlock-unlocked-mutex
branch
from
August 18, 2026 11:46
a56b2df to
7d41a16
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/fix-unlock-unlocked-mutex
branch
from
August 18, 2026 11:48
7d41a16 to
51e41d0
Compare
Mockird31
approved these changes
Aug 18, 2026
sssciel
requested changes
Aug 19, 2026
The wait channel was closed while the future's mutex was still held, so a caller woken by WaitChan() could call Release() and zero the future before the internal goroutine finished unlocking the mutex. This caused "unlock of unlocked mutex" panics under concurrent load. Follows #595
oleg-jukovec
force-pushed
the
oleg-jukovec/fix-unlock-unlocked-mutex
branch
from
August 19, 2026 06:32
51e41d0 to
02d4cba
Compare
sssciel
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wait channel was closed while the future's mutex was still held, so a caller woken by WaitChan() could call Release() and zero the future before the internal goroutine finished unlocking the mutex. This caused "unlock of unlocked mutex" panics under concurrent load.
Follows #595
What has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):
Follows #595