settings: use a bezeled multi-line text field for notes on macOS - #7906
Merged
Merged
Conversation
The macOS notes box was a TextEditor with a hand-drawn half-point border, which did not match the bezel of the name field above it and had no focus ring. A TextField with a vertical axis has the right look but submits on Return instead of inserting a newline, and a drawn overlay cannot follow the bezel style of each macOS release. Wrap an NSTextField configured for wrapping instead, so AppKit draws the same bezel, highlight and focus ring as the name field on every supported macOS version. Return is routed through the field editor to insert a newline, the field grows with its contents from a 200pt minimum, and the page's disableAutocorrection setting is applied to the field editor as the TextEditor did. iOS keeps the TextEditor. Assisted-by: Claude:claude-fable-5-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS notes box was a
TextEditorwith a hand-drawn half-point border that did not match the bezel of the Name field above it, had no focus ring, and bled square corners under the drawn outline in dark mode. A vertical-axisTextFieldlooks right but submits on Return, and a drawn overlay cannot track the bezel style of each macOS release (12/13 differ from 26+).This wraps an
NSTextFieldconfigured for wrapping so AppKit draws the same bezel, highlight and focus ring as the Name field on every supported macOS version. Return inserts a newline through the field editor, the field grows with its contents from a 200pt minimum, and the page'sdisableAutocorrectionis applied to the field editor as theTextEditordid. iOS keeps theTextEditor.Testing: Tested by a human on macOS 27.0 and macOS 12.6 VM, Mac. The author acknowledges that this change has been tested and/or reviewed by a human in accordance with UTM's AI contribution guidelines.